From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Mon, 5 Nov 2018 18:40:49 +0000 (+0000)
Subject: tools: ipxe: Correct download error handling
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=58f904c4cf9fc5a49e7807fd91cd2523fa8dd191;p=people%2Fsstabellini%2Fxen-unstable.git%2F.git

tools: ipxe: Correct download error handling

This shell fragment lacked set -e.  So, eg if the download failed a
broken ipxe.tar.gz would be left behind.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Tested-by: Paul Durrant <paul.durrant@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---

diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
index 3868f876ea..fd8dfdf5a7 100644
--- a/tools/firmware/etherboot/Makefile
+++ b/tools/firmware/etherboot/Makefile
@@ -33,7 +33,7 @@ $(ROM): $(ROMS)
 	$(MAKE) -C $D/src bin/$(*F).rom
 
 $T:
-	if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
+	set -e; if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
 		$(GIT) clone $(IPXE_GIT_URL) $D.git; \
 		(cd $D.git && $(GIT) archive --format=tar --prefix=$D/ \
 		$(IPXE_GIT_TAG) | gzip -n >../_$T); \