From: Peter Krempa Date: Tue, 9 Oct 2018 08:55:00 +0000 (+0200) Subject: qemu: domain: Initialize proper element in qemuDomainPrepareStorageSourceBlockdev X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=58da6e3c267922f0c723c97476dc4087baf5efe0;p=libvirt.git qemu: domain: Initialize proper element in qemuDomainPrepareStorageSourceBlockdev We are preparing a certain disk source passed in as '@src' so the individual functions should use that rather than disk->src which corresponds to the top level element of the chain only. Without this change TLS and persistent reservations would not work for backing images of a chain when using -blockdev. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 9ed7115dab..509da6bfea 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -13462,10 +13462,10 @@ qemuDomainPrepareStorageSourceBlockdev(virDomainDiskDefPtr disk, src->nodeformat) < 0) return -1; - if (qemuDomainPrepareStorageSourcePR(disk->src, priv, src->nodestorage) < 0) + if (qemuDomainPrepareStorageSourcePR(src, priv, src->nodestorage) < 0) return -1; - if (qemuDomainPrepareStorageSourceTLS(disk->src, cfg, src->nodestorage, + if (qemuDomainPrepareStorageSourceTLS(src, cfg, src->nodestorage, priv->qemuCaps) < 0) return -1;