From: Alex Jia <ajia@redhat.com>
Date: Tue, 16 Aug 2011 09:24:26 +0000 (+0800)
Subject: libvirt: avoid dead store in virDomainMigrateVersion3
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=5495e45e70d10508a5a442114c0b8aa67d8bf807;p=libvirt.git

libvirt: avoid dead store in virDomainMigrateVersion3

* src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence
  clang warning.

Detected by ccc-analyzer:

libvirt.c:4277:5: warning: Value stored to 'ret' is never read
    ret = domain->conn->driver->domainMigrateConfirm3
    ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---

diff --git a/src/libvirt.c b/src/libvirt.c
index 7f1ff83486..c5cd60dfd1 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -4289,6 +4289,9 @@ confirm:
      * do, but fortunately worst case is that there is a
      * domain left in 'paused' state on source.
      */
+    if (ret < 0)
+        VIR_WARN("Guest %s probably left in 'paused' state on source",
+                 domain->name);
 
  done:
     if (orig_err) {