From: Fam Zheng Date: Tue, 10 Jul 2018 06:31:23 +0000 (+0800) Subject: block: Fix bdrv_co_truncate overlap check X-Git-Tag: qemu-xen-4.12.0-rc1~79^2~1 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=5416a11eb55d46c376dde97c429b89e9b4e1a94f;p=qemu-xen.git block: Fix bdrv_co_truncate overlap check If we are growing the image and potentially using preallocation for the new area, we need to make sure that no write requests are made to the "preallocated" area which is [@old_size, @offset), not [@offset, offset * 2 - @old_size). Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- diff --git a/block/io.c b/block/io.c index 2832214db4..77d38ca1d3 100644 --- a/block/io.c +++ b/block/io.c @@ -3136,7 +3136,8 @@ int coroutine_fn bdrv_co_truncate(BdrvChild *child, int64_t offset, } bdrv_inc_in_flight(bs); - tracked_request_begin(&req, bs, offset, new_bytes, BDRV_TRACKED_TRUNCATE); + tracked_request_begin(&req, bs, offset - new_bytes, new_bytes, + BDRV_TRACKED_TRUNCATE); /* If we are growing the image and potentially using preallocation for the * new area, we need to make sure that no write requests are made to it