From: Martin Kletzander <mkletzan@redhat.com>
Date: Tue, 18 Sep 2012 10:01:46 +0000 (+0200)
Subject: secret: Fix error for private secrets
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=54106114a4b2b0261fedc9235e986656d61d80ef;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

secret: Fix error for private secrets

When trying to get the value of a private secret, the code used
'operation denied' error. That error is specified as a error for
read-only connections trying to perform denied operation. The
following error seems more accurate.

To compare the difference:
 - BEFORE
error: operation secret is private forbidden for read only access

 - AFTER
error: Invalid secret: secret is private
---

diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c
index 2ad66dd3e..67c7323b1 100644
--- a/src/secret/secret_driver.c
+++ b/src/secret/secret_driver.c
@@ -1,7 +1,7 @@
 /*
  * secret_driver.c: local driver for secret manipulation API
  *
- * Copyright (C) 2009-2011 Red Hat, Inc.
+ * Copyright (C) 2009-2012 Red Hat, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -990,7 +990,7 @@ secretGetValue(virSecretPtr obj, size_t *value_size, unsigned int flags,
 
     if ((internalFlags & VIR_SECRET_GET_VALUE_INTERNAL_CALL) == 0 &&
         secret->def->private) {
-        virReportError(VIR_ERR_OPERATION_DENIED, "%s",
+        virReportError(VIR_ERR_INVALID_SECRET, "%s",
                        _("secret is private"));
         goto cleanup;
     }