From: Andreas Färber Date: Fri, 15 Feb 2013 15:43:08 +0000 (+0100) Subject: spapr_hcall: Replace open-coded CPU loop with qemu_get_cpu() X-Git-Tag: qemu-xen-4.4.0-rc1~6^2~1111^2~4 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=5353d03dd7917875b46ff03e0d9e2935770f5e9d;p=qemu-upstream-4.6-testing.git spapr_hcall: Replace open-coded CPU loop with qemu_get_cpu() The helper functions all access ppc-specific fields only so don't bother to change arguments to PowerPCCPU and use env_ptr instead. No functional change. Acked-by: Alexander Graf Signed-off-by: Andreas Färber --- diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c index af1db6ea0..7b8959488 100644 --- a/hw/spapr_hcall.c +++ b/hw/spapr_hcall.c @@ -469,16 +469,11 @@ static target_ulong h_register_vpa(PowerPCCPU *cpu, sPAPREnvironment *spapr, CPUPPCState *tenv; CPUState *tcpu; - for (tenv = first_cpu; tenv; tenv = tenv->next_cpu) { - tcpu = CPU(ppc_env_get_cpu(tenv)); - if (tcpu->cpu_index == procno) { - break; - } - } - - if (!tenv) { + tcpu = qemu_get_cpu(procno); + if (!tcpu) { return H_PARAMETER; } + tenv = tcpu->env_ptr; switch (flags) { case FLAGS_REGISTER_VPA: