From: Christophe Lyon Date: Tue, 15 Feb 2011 13:44:44 +0000 (+0000) Subject: target-arm: fix unsigned 64 bit right shifts. X-Git-Tag: qemu-xen-4.3.0-rc1~3389 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=51e3930fc7ae8d3cff1ff0ecfdd63403b4c20f36;p=qemu-upstream-4.4-testing.git target-arm: fix unsigned 64 bit right shifts. Fix range of shift amounts which always give 0 as result. Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell Signed-off-by: Aurelien Jarno --- diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index 52ef994d2..c97aa7dbd 100644 --- a/target-arm/neon_helper.c +++ b/target-arm/neon_helper.c @@ -639,7 +639,7 @@ uint32_t HELPER(neon_rshl_u32)(uint32_t val, uint32_t shiftop) uint64_t HELPER(neon_rshl_u64)(uint64_t val, uint64_t shiftop) { int8_t shift = (uint8_t)shiftop; - if (shift >= 64 || shift < 64) { + if (shift >= 64 || shift < -64) { val = 0; } else if (shift == -64) { /* Rounding a 1-bit result just preserves that bit. */