From: Jamin Lin Date: Tue, 25 Jun 2024 07:07:40 +0000 (+0800) Subject: aspeed/sdmc: Remove extra R_MAIN_STATUS case X-Git-Tag: qemu-xen-4.20.0~92^2~1 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=50c527b9ef58086dc377a0fa5e3053d16fc5728e;p=qemu-xen.git aspeed/sdmc: Remove extra R_MAIN_STATUS case Coverity reports that the newly added 'case R_MAIN_STATUS' is DEADCODE because it can not be reached. This is because R_MAIN_STATUS is handled before in the "Unprotected registers" switch statement. Remove it. Fixes: Coverity CID 1547112 Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater [ clg: Rewrote commit log ] Signed-off-by: Cédric Le Goater --- diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c index 44da085e10..ebf139cb5c 100644 --- a/hw/misc/aspeed_sdmc.c +++ b/hw/misc/aspeed_sdmc.c @@ -595,7 +595,6 @@ static void aspeed_2700_sdmc_write(AspeedSDMCState *s, uint32_t reg, case R_INT_STATUS: case R_INT_CLEAR: case R_INT_MASK: - case R_MAIN_STATUS: case R_ERR_STATUS: case R_ECC_FAIL_STATUS: case R_ECC_FAIL_ADDR: