From: Michal Privoznik Date: Mon, 11 Jan 2016 12:34:17 +0000 (+0100) Subject: virDomainGetTime: Deny on RO connections X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=506e9d6c2d4baaf580d489fff0690c0ff2ff588f;p=libvirt.git virDomainGetTime: Deny on RO connections We have a policy that if API may end up talking to a guest agent it should require RW connection. We don't obey the rule in virDomainGetTime(). Signed-off-by: Michal Privoznik --- diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 02fc4df45d..9491845758 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -10934,6 +10934,7 @@ virDomainGetTime(virDomainPtr dom, virResetLastError(); virCheckDomainReturn(dom, -1); + virCheckReadOnlyGoto(dom->conn->flags, error); if (dom->conn->driver->domainGetTime) { int ret = dom->conn->driver->domainGetTime(dom, seconds,