From: Nicola Vetrini Date: Thu, 25 Apr 2024 07:50:33 +0000 (+0200) Subject: x86/acpi: address violations of MISRA Rule 20.7 X-Git-Tag: 4.19.0-rc1~290 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4f900035a4a8373805dd94e4247b4645d26f8c6d;p=xen.git x86/acpi: address violations of MISRA Rule 20.7 MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c index c6fa810a6b..610937f42e 100644 --- a/xen/arch/x86/acpi/power.c +++ b/xen/arch/x86/acpi/power.c @@ -422,12 +422,12 @@ static void tboot_sleep(u8 sleep_state) { uint32_t shutdown_type; -#define TB_COPY_GAS(tbg, g) \ - tbg.space_id = g.space_id; \ - tbg.bit_width = g.bit_width; \ - tbg.bit_offset = g.bit_offset; \ - tbg.access_width = g.access_width; \ - tbg.address = g.address; +#define TB_COPY_GAS(tbg, g) \ + (tbg).space_id = (g).space_id; \ + (tbg).bit_width = (g).bit_width; \ + (tbg).bit_offset = (g).bit_offset; \ + (tbg).access_width = (g).access_width; \ + (tbg).address = (g).address; /* sizes are not same (due to packing) so copy each one */ TB_COPY_GAS(g_tboot_shared->acpi_sinfo.pm1a_cnt_blk,