From: Wendy Liang <jliang@xilinx.com>
Date: Fri, 7 Jun 2013 03:05:38 +0000 (+1000)
Subject: xilinx_axidma: Do not set DMA .notify to NULL after notify
X-Git-Tag: qemu-xen-4.4.0-rc1~6^2~322
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4f293bd6e53739e089f33b458f70a9c4ac136b92;p=qemu-upstream-4.6-testing.git

xilinx_axidma: Do not set DMA .notify to NULL after notify

If a stream notify function is not ready, it may re-populate the notify call-
back to indicate it should be re-polled later. This break in this usage, as
immediately following the notify() call, .notify is set to NULL. reverse the
ordering of the notify call and NULL assignment accordingly.

[PC: Reworked commit message]

Signed-off-by: Wendy Liang <jliang@xilinx.com>
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
---

diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
index 3a3ef8aff..50054cf85 100644
--- a/hw/dma/xilinx_axidma.c
+++ b/hw/dma/xilinx_axidma.c
@@ -514,8 +514,9 @@ static void axidma_write(void *opaque, hwaddr addr,
             break;
     }
     if (sid == 1 && d->notify) {
-        d->notify(d->notify_opaque);
+        StreamCanPushNotifyFn notifytmp = d->notify;
         d->notify = NULL;
+        notifytmp(d->notify_opaque);
     }
     stream_update_irq(s);
 }