From: John Ferlan <jferlan@redhat.com>
Date: Fri, 19 Feb 2016 18:54:45 +0000 (-0500)
Subject: zfs: Resolve RESOURCE_LEAK
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4e87164306f4bead094429ab9e520dfd1b58199f;p=libvirt.git

zfs: Resolve RESOURCE_LEAK

Found by my Coverity checker - virCheckFlags call could return -1, but
not virCommandFree(destroy_cmd).

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c
index 6bf79634e1..4d04c70354 100644
--- a/src/storage/storage_backend_zfs.c
+++ b/src/storage/storage_backend_zfs.c
@@ -355,10 +355,12 @@ virStorageBackendZFSDeleteVol(virConnectPtr conn ATTRIBUTE_UNUSED,
                               unsigned int flags)
 {
     int ret = -1;
-    virCommandPtr destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL);
+    virCommandPtr destroy_cmd = NULL;
 
     virCheckFlags(0, -1);
 
+    destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL);
+
     virCommandAddArgFormat(destroy_cmd, "%s/%s",
                            pool->def->source.name, vol->name);