From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 28 Mar 2014 14:22:49 +0000 (+0000)
Subject: dma-helpers: Initialize DMAAIOCB in_cancel flag
X-Git-Tag: qemu-xen-4.5.0-rc1~50^2~2
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4d1cb6e6f51b0d8405f701806a203a73e7431fe5;p=qemu-upstream-4.5-testing.git

dma-helpers: Initialize DMAAIOCB in_cancel flag

Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get()
does not return zero-initialized memory. Spotted by the clang sanitizer
(which complained when the value loaded in dma_complete() was not valid
for a bool type); this might have resulted in leaking the AIO block.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/dma-helpers.c b/dma-helpers.c
index c9620a5bb..5f421e981 100644
--- a/dma-helpers.c
+++ b/dma-helpers.c
@@ -213,6 +213,7 @@ BlockDriverAIOCB *dma_bdrv_io(
     dbs->sg_cur_index = 0;
     dbs->sg_cur_byte = 0;
     dbs->dir = dir;
+    dbs->in_cancel = false;
     dbs->io_func = io_func;
     dbs->bh = NULL;
     qemu_iovec_init(&dbs->iov, sg->nsg);