From: Fam Zheng Date: Fri, 13 Oct 2017 01:19:54 +0000 (+0800) Subject: docker: Don't allocate tty unless DEBUG=1 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4b2c6bc563c13f242d92fe4f8f31d22b31788858;p=people%2Fpauldu%2Fqemu.git docker: Don't allocate tty unless DEBUG=1 The existence of tty in the container seems to urge gcc into colorizing the errors, but the escape chars will clutter the report once turned into email replies on patchew. Move -t to debug mode. Reported-by: Eric Blake Signed-off-by: Fam Zheng Message-Id: <20171013011954.9975-1-famz@redhat.com> Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 6f9ea196a7..ab939f2bec 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -134,10 +134,10 @@ docker-run: docker-qemu-src " COPYING $(EXECUTABLE) to $(IMAGE)")) $(call quiet-command, \ $(SRC_PATH)/tests/docker/docker.py run \ - $(if $(NOUSER),,-u $(shell id -u)) -t \ + $(if $(NOUSER),,-u $(shell id -u)) \ --security-opt seccomp=unconfined \ $(if $V,,--rm) \ - $(if $(DEBUG),-i,) \ + $(if $(DEBUG),-ti,) \ $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \ -e TARGET_LIST=$(TARGET_LIST) \ -e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \