From: Paul Durrant <paul.durrant@citrix.com>
Date: Fri, 11 Nov 2016 14:58:25 +0000 (+0000)
Subject: Don't call DbgPrint (or variants) from an event channel callback
X-Git-Tag: 8.2.0-rc1~2
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=488cdd59ccabfa1d26493638d5946080567b2dfc;p=pvdrivers%2Fwin%2Fxeniface.git

Don't call DbgPrint (or variants) from an event channel callback

Windows debug primitives will IPI so it's not a good idea to use them
from within an interrupt handler which may get called at HIGH_LEVEL.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---

diff --git a/src/xeniface/ioctl_evtchn.c b/src/xeniface/ioctl_evtchn.c
index 5fb8bec..b9b0e27 100644
--- a/src/xeniface/ioctl_evtchn.c
+++ b/src/xeniface/ioctl_evtchn.c
@@ -84,10 +84,7 @@ EvtchnInterruptHandler(
     KeGetCurrentProcessorNumberEx(&ProcNumber);
     ProcIndex = KeGetProcessorIndexFromNumber(&ProcNumber);
 
-    if (!KeInsertQueueDpc(&Context->Dpc, NULL, NULL)) {
-        XenIfaceDebugPrint(TRACE, "NOT INSERTED: Context %p, Port %lu, FO %p, Cpu %lu\n",
-                           Context, Context->LocalPort, Context->FileObject, ProcIndex);
-    }
+    (VOID) KeInsertQueueDpc(&Context->Dpc, NULL, NULL);
 
     return TRUE;
 }