From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 5 Aug 2016 10:03:59 +0000 (+0100)
Subject: hw/sparc/leon3: Don't call get_image_size() on a NULL pointer
X-Git-Tag: qemu-xen-4.8.0-rc1~51
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=47dc0ec576c3d8748985e34d273c8dc0465c5ddb;p=qemu-xen.git

hw/sparc/leon3: Don't call get_image_size() on a NULL pointer

get_image_size() doesn't handle being passed a NULL pointer, so
avoid doing that. Spotted by the clang ub sanitizer (which notices
the attempt to pass NULL to open()).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1470391439-28427-1-git-send-email-peter.maydell@linaro.org
---

diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index dbae41f3a4..6e16478413 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -171,7 +171,11 @@ static void leon3_generic_hw_init(MachineState *machine)
     }
     filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
 
-    bios_size = get_image_size(filename);
+    if (filename) {
+        bios_size = get_image_size(filename);
+    } else {
+        bios_size = -1;
+    }
 
     if (bios_size > prom_size) {
         fprintf(stderr, "qemu: could not load prom '%s': file too big\n",