From: Daniil Tatianin <d-tatianin@yandex-team.ru>
Date: Wed, 17 Nov 2021 14:23:49 +0000 (+0300)
Subject: chardev/wctable: don't free the instance in wctablet_chr_finalize
X-Git-Tag: qemu-xen-4.16.1~2^2~11
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4658dfcbc09dcc90025604cce64d6fd01952b882;p=qemu-xen.git

chardev/wctable: don't free the instance in wctablet_chr_finalize

Object is supposed to be freed by invoking obj->free, and not
obj->instance_finalize. This would lead to use-after-free followed by
double free in object_unref/object_finalize.

Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20211117142349.836279-1-d-tatianin@yandex-team.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit fdc6e168181d06391711171b7c409b34f2981ced)
Signed-off-by: Michael Roth <michael.roth@amd.com>
---

diff --git a/chardev/wctablet.c b/chardev/wctablet.c
index 95e005f5a5..e8b292c43c 100644
--- a/chardev/wctablet.c
+++ b/chardev/wctablet.c
@@ -320,7 +320,6 @@ static void wctablet_chr_finalize(Object *obj)
     TabletChardev *tablet = WCTABLET_CHARDEV(obj);
 
     qemu_input_handler_unregister(tablet->hs);
-    g_free(tablet);
 }
 
 static void wctablet_chr_open(Chardev *chr,