From: John Ferlan <jferlan@redhat.com>
Date: Fri, 13 Feb 2015 20:09:09 +0000 (-0500)
Subject: libxl: Resolve Coverity CHECKED_RETURN
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4438646c0d7ff5c4857e6b010032f0fdf0a6039c;p=libvirt.git

libxl: Resolve Coverity CHECKED_RETURN

Periodically my Coverity scan will return a checked_return failure
for libxlDomainShutdownThread call to libxlDomainStart. Followed the
libxlAutostartDomain example in order to check the status, emit a
message, and continue on.
---

diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index f0eaf6c671..21c41d7424 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -685,7 +685,11 @@ libxlDomainShutdownThread(void *opaque)
     }
     libxl_domain_destroy(ctx, vm->def->id, NULL);
     libxlDomainCleanupJob(driver, vm, VIR_DOMAIN_SHUTOFF_SHUTDOWN);
-    libxlDomainStart(driver, vm, 0, -1);
+    if (libxlDomainStart(driver, vm, false, -1) < 0) {
+        virErrorPtr err = virGetLastError();
+        VIR_ERROR(_("Failed to restart VM '%s': %s"),
+                  vm->def->name, err ? err->message : _("unknown error"));
+    }
 
  cleanup:
     if (vm)