From: Chris Lalancette <clalance@redhat.com>
Date: Fri, 30 Jul 2010 13:39:48 +0000 (-0400)
Subject: Fix a memory leak in the qemudBuildCommandLine.
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4313e1b9b12adcfda6972eab5ac69fb5d3e64bf0;p=libvirt.git

Fix a memory leak in the qemudBuildCommandLine.

ADD_ARG_LIT should only be used for literal arguments,
since it duplicates the memory.  Since virBufferContentAndReset
is already allocating memory, we should only use ADD_ARG.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
---

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 7c63bdcb30..a79e0d7d84 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -4110,7 +4110,7 @@ int qemudBuildCommandLine(virConnectPtr conn,
                 goto error;
             }
 
-            ADD_ARG_LIT(virBufferContentAndReset(&boot_buf));
+            ADD_ARG(virBufferContentAndReset(&boot_buf));
         }
 
         if (def->os.kernel) {