From: Martin Kletzander <mkletzan@redhat.com>
Date: Wed, 22 Jun 2016 15:27:46 +0000 (+0200)
Subject: Don't allow raneming domains to empty strings
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=428d2dfdb8ca41fde215364a06b5bd43901b5817;p=libvirt.git

Don't allow raneming domains to empty strings

It may cause unwanted behaviour (of course, is there any wanted one for
that case?) so we should rather disable the possibility of doing so.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1320893

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 2ca054a328..4e71a94389 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -8790,7 +8790,7 @@ virDomainRename(virDomainPtr dom,
 
     virResetLastError();
     virCheckDomainReturn(dom, -1);
-    virCheckNonNullArgGoto(new_name, error);
+    virCheckNonEmptyStringArgGoto(new_name, error);
     virCheckReadOnlyGoto(dom->conn->flags, error);
 
     if (dom->conn->driver->domainRename) {