From: Owen Smith <owen.smith@cloud.com>
Date: Tue, 22 Aug 2023 11:30:04 +0000 (+0100)
Subject: ASSERT Cache method parameters
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=41f12439fb00b0e593e7d8f7bba12928c62d253b;p=pvdrivers%2Fwin%2Fxenbus.git

ASSERT Cache method parameters

ASSERT the Cache public interface methods are passed valid parameters.

Signed-off-by: Owen Smith <owen.smith@cloud.com>
---

diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
index 00e16f6..6229aed 100644
--- a/src/xenbus/cache.c
+++ b/src/xenbus/cache.c
@@ -602,6 +602,8 @@ CacheGet(
 
     UNREFERENCED_PARAMETER(Interface);
 
+    ASSERT(Cache != NULL);
+
     KeRaiseIrql(DISPATCH_LEVEL, &Irql);
     Index = KeGetCurrentProcessorNumberEx(NULL);
 
@@ -678,6 +680,9 @@ CachePut(
 
     UNREFERENCED_PARAMETER(Interface);
 
+    ASSERT(Cache != NULL);
+    ASSERT(Object != NULL);
+
     KeRaiseIrql(DISPATCH_LEVEL, &Irql);
     Index = KeGetCurrentProcessorNumberEx(NULL);
 
@@ -837,6 +842,14 @@ CacheCreate(
     KIRQL                   Irql;
     NTSTATUS                status;
 
+    ASSERT(Name != NULL);
+    ASSERT(Size != 0);
+    ASSERT(Ctor != NULL);
+    ASSERT(Dtor != NULL);
+    ASSERT(AcquireLock != NULL);
+    ASSERT(ReleaseLock != NULL);
+    ASSERT(Cache != NULL);
+
     Trace("====> (%s)\n", Name);
 
     *Cache = __CacheAllocate(sizeof (XENBUS_CACHE));
@@ -968,6 +981,8 @@ CacheDestroy(
     PXENBUS_CACHE_CONTEXT   Context = Interface->Context;
     KIRQL                   Irql;
 
+    ASSERT(Cache != NULL);
+
     Trace("====> (%s)\n", Cache->Name);
 
     KeAcquireSpinLock(&Context->Lock, &Irql);