From: Daniel P. Berrange <berrange@redhat.com>
Date: Fri, 3 Jul 2015 15:51:56 +0000 (+0100)
Subject: rpc: ensure daemon is spawn even if dead socket exists
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=406ee8c226d2197ba1aaecb9cf3ad2b6df31ae44;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

rpc: ensure daemon is spawn even if dead socket exists

The auto-spawn code would originally attempt to spawn the
daemon for both ENOENT and ECONNREFUSED errors from connect().
The various refactorings eventually lost this so we only
spawn the daemon on ENOENT. The result is if the daemon exits
uncleanly, so that the socket is left in the filesystem, we
will never be able to auto-spawn the daemon again.
---

diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index 3d7508110..106d09aaf 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
@@ -681,7 +681,8 @@ int virNetSocketNewConnectUNIX(const char *path,
 
     while (retries &&
            connect(fd, &remoteAddr.data.sa, remoteAddr.len) < 0) {
-        if (!(spawnDaemon && errno == ENOENT)) {
+        if (!(spawnDaemon && (errno == ENOENT ||
+                              errno == ECONNREFUSED))) {
             virReportSystemError(errno, _("Failed to connect socket to '%s'"),
                                  path);
             goto cleanup;