From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 19 Jun 2014 17:06:25 +0000 (+0100)
Subject: target-arm/translate-a64.c: Fix dead ?: in handle_simd_shift_fpint_conv()
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4063452eca8aaa432b5c42b1ccea81be01219b0e;p=people%2Fliuw%2Flibxenctrl-split%2Fqemu-xen.git

target-arm/translate-a64.c: Fix dead ?: in handle_simd_shift_fpint_conv()

In handle_simd_shift_fpint_conv(), the combination of is_double == true,
is_scalar == false and is_q == false is an unallocated encoding; the
'both parts false' case of the nested ?: expression for calculating
maxpass is therefore unreachable and can be removed.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Message-id: 1402171881-14343-4-git-send-email-peter.maydell@linaro.org
---

diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index cbc8a3574..33b5025fe 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -6539,7 +6539,7 @@ static void handle_simd_shift_fpint_conv(DisasContext *s, bool is_scalar,
     tcg_shift = tcg_const_i32(fracbits);
 
     if (is_double) {
-        int maxpass = is_scalar ? 1 : is_q ? 2 : 1;
+        int maxpass = is_scalar ? 1 : 2;
 
         for (pass = 0; pass < maxpass; pass++) {
             TCGv_i64 tcg_op = tcg_temp_new_i64();