From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 18 Jun 2015 09:37:17 +0000 (+0200)
Subject: rpc: Actually increase reference count on @srv in virNetDaemonAddServer
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=4002395dd7180158aa32adc31ab61a2f155380df;p=libvirt.git

rpc: Actually increase reference count on @srv in virNetDaemonAddServer

VIR_APPEND_ELEMENT would clear @srv to NULL after it successfully
inserted it thus the reference count could not be increased afterwards.

Switch to VIR_APPEND_ELEMENT_COPY. This fixes crash after terminating
the daemon.
---

diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c
index a6d6a4bd84..67dff147be 100644
--- a/src/rpc/virnetdaemon.c
+++ b/src/rpc/virnetdaemon.c
@@ -162,7 +162,7 @@ virNetDaemonAddServer(virNetDaemonPtr dmn, virNetServerPtr srv)
 
     virObjectLock(dmn);
 
-    if (VIR_APPEND_ELEMENT(dmn->servers, dmn->nservers, srv) < 0)
+    if (VIR_APPEND_ELEMENT_COPY(dmn->servers, dmn->nservers, srv) < 0)
         goto cleanup;
 
     virObjectRef(srv);