From: Peter Krempa Date: Tue, 26 Apr 2016 12:18:04 +0000 (+0200) Subject: qemu: remove default case from few typecasted enums X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=3fbc7b781c61506780f9902f964439b962cfb1a6;p=libvirt.git qemu: remove default case from few typecasted enums Commit 98c5c53d69b partially reverted the effort to use typecasted enums for compiler notification. Turn it back. --- diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6fbfe215bf..3b6d2726a7 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4281,7 +4281,9 @@ qemuBuildPCIHostdevDevStr(const virDomainDef *def, virBufferAddLit(&buf, "vfio-pci"); break; - default: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_TYPE_LAST: virReportError(VIR_ERR_INTERNAL_ERROR, _("invalid PCI passthrough type '%s'"), virDomainHostdevSubsysPCIBackendTypeToString(backend)); diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 6e30dc1292..31cd030367 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1249,7 +1249,16 @@ qemuDomainAttachHostPCIDevice(virQEMUDriverPtr driver, } break; - default: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM: + break; + + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_TYPE_LAST: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("QEMU does not support device assignment mode '%s'"), + virDomainHostdevSubsysPCIBackendTypeToString(backend)); + goto error; break; }