From: Alexander Graf <agraf@suse.de>
Date: Sat, 23 Jul 2011 09:09:23 +0000 (+0200)
Subject: PPC: MPIC: Remove read functionality for WO registers
X-Git-Tag: qemu-xen-4.2.0~319^2~6^2~55
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=3ee82442c53e342883eb6f05b1776b05892e336f;p=qemu-xen.git

PPC: MPIC: Remove read functionality for WO registers

The IPI dispatch registers are write only according to every MPIC
spec I have found. So instead of pretending you could read back something
from them, better not handle them at all.

Reported-by: Elie Richa <richa@adacore.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---

diff --git a/hw/openpic.c b/hw/openpic.c
index 31ad1751fe..dfec52e2e2 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -952,13 +952,6 @@ static uint32_t openpic_cpu_read_internal(void *opaque, target_phys_addr_t addr,
     case 0xB0: /* PEOI */
         retval = 0;
         break;
-#if MAX_IPI > 0
-    case 0x40: /* IDE */
-    case 0x50:
-        idx = (addr - 0x40) >> 4;
-        retval = read_IRQreg(opp, opp->irq_ipi0 + idx, IRQ_IDE);
-        break;
-#endif
     default:
         break;
     }