From: Matthew Daley Date: Wed, 18 Sep 2013 03:38:03 +0000 (+1200) Subject: mini-os: fix various memory leaks in various locations X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=3b82ca8127b7f71b271015f31a7d18017073de7d;p=people%2Fliuw%2Flibxenctrl-split%2Fmini-os.git mini-os: fix various memory leaks in various locations Coverity-ID: 1055827 Coverity-ID: 1055828 Coverity-ID: 1055829 Coverity-ID: 1055830 Coverity-ID: 1055831 Signed-off-by: Matthew Daley Acked-by: Samuel Thibault --- diff --git a/kernel.c b/kernel.c index e9402b9..24fa25c 100644 --- a/kernel.c +++ b/kernel.c @@ -84,8 +84,10 @@ static void shutdown_thread(void *p) free(err); xenbus_wait_for_watch(&events); } - xenbus_unwatch_path_token(XBT_NIL, path, token); - xenbus_write(XBT_NIL, path, ""); + err = xenbus_unwatch_path_token(XBT_NIL, path, token); + if (err) free(err); + err = xenbus_write(XBT_NIL, path, ""); + if (err) free(err); printk("Shutting down (%s)\n", shutdown); if (!strcmp(shutdown, "poweroff")) @@ -96,6 +98,7 @@ static void shutdown_thread(void *p) /* Unknown */ shutdown_reason = SHUTDOWN_crash; app_shutdown(shutdown_reason); + free(shutdown); } #endif diff --git a/lib/xs.c b/lib/xs.c index c603d17..324bd05 100644 --- a/lib/xs.c +++ b/lib/xs.c @@ -144,6 +144,7 @@ char **xs_directory(struct xs_handle *h, xs_transaction_t t, msg = xenbus_ls(t, path, &res); if (msg) { printk("xs_directory(%s): %s\n", path, msg); + free(msg); return NULL; } @@ -163,6 +164,7 @@ char **xs_directory(struct xs_handle *h, xs_transaction_t t, } *num = n; + free(res); return entries; }