From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Fri, 31 Jul 2020 11:06:41 +0000 (+0100)
Subject: cs-bisection-step: Break out qtxt_common_ok
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=3a9a1077398a0588302cf2f15853fc0c433f167c;p=osstest.git

cs-bisection-step: Break out qtxt_common_ok

Make this bit of query into a subref which takes a $table argument.

No change to the generated query.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
v2: New patch.
---

diff --git a/cs-bisection-step b/cs-bisection-step
index f11726a..ba0c642 100755
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -190,6 +190,13 @@ sub flight_rmap ($$) {
 END
     };
 
+    my $qtxt_common_tree_ok = sub {
+	my ($table) = @_;
+	[<<END];
+  	      $table.name LIKE E'tree\\_%'
+END
+    };
+
     $dbh_tests->do(<<END, {});
           CREATE TEMP TABLE tmp_build_info (
               use varchar NOT NULL,
@@ -267,7 +274,7 @@ $qtxt_common_tables
 
            WHERE
 @{ $qtxt_common_rev_ok->('rev') } AND
-  	          url.name LIKE E'tree\\_%'
+@{ $qtxt_common_tree_ok->('url') }
 	     AND  url.use = rev.use
 	     AND  url.job = rev.job
 	     AND (rev.name = 'built_revision_' || substr(url.name,6) OR