From: Adam Julis <ajulis@redhat.com>
Date: Fri, 21 Jun 2024 16:16:55 +0000 (+0200)
Subject: qemuDomainDiskChangeSupported: Fill in missing check
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=3a9095976e1060f95a8a4a985d5e9901e1098547;p=libvirt.git

qemuDomainDiskChangeSupported: Fill in missing check

The attribute 'discard_no_unref' of <disk/> is not allowed to be
changed while the virtual machine is running.

Resolves: https://issues.redhat.com/browse/RHEL-37542
Signed-off-by: Adam Julis <ajulis@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2c8f5b1aad..1a90311ca5 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -8459,6 +8459,7 @@ qemuDomainDiskChangeSupported(virDomainDiskDef *disk,
     CHECK_EQ(ioeventfd, "ioeventfd", true);
     CHECK_EQ(event_idx, "event_idx", true);
     CHECK_EQ(copy_on_read, "copy_on_read", true);
+    CHECK_EQ(discard_no_unref, "discard_no_unref", true);
     /* "snapshot" is a libvirt internal field and thus can be changed */
     /* startupPolicy is allowed to be updated. Therefore not checked here. */
     CHECK_EQ(transient, "transient", true);