From: Peter Krempa Date: Wed, 6 Apr 2016 12:34:05 +0000 (+0200) Subject: qemu: command: Drop obsolete comment X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=388b356e5d27e571d603558c5eb8588a453fa448;p=libvirt.git qemu: command: Drop obsolete comment The change that made qemu not add the memballoon by default happened prior to 0.12.0. Additionaly the comment was misleading due to the code that was added below. Since we always need to add a balloon on the commandline drop the comment. --- diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0662e39136..90d577366d 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3526,12 +3526,7 @@ qemuBuildMemballoonCommandLine(virCommandPtr cmd, virQEMUCapsPtr qemuCaps) { char *optstr; - /* QEMU changed its default behavior to not include the virtio balloon - * device. Explicitly request it to ensure it will be present. - * - * NB: Earlier we declared that VirtIO balloon will always be in - * slot 0x3 on bus 0x0 - */ + if (STREQLEN(def->os.machine, "s390-virtio", 10) && virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_S390) && def->memballoon) def->memballoon->model = VIR_DOMAIN_MEMBALLOON_MODEL_NONE;