From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 27 Sep 2012 09:17:19 +0000 (+0200)
Subject: qemu: Fix misleading comment for qemuDomainObjBeginJobWithDriver()
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=36f7dbf4dc364e708474d5cedc64b8edb5659e5b;p=libvirt.git

qemu: Fix misleading comment for qemuDomainObjBeginJobWithDriver()

The comment stated that you may call qemuDomainObjBeginJobWithDriver
without passing qemud_driver to signal it's not locked.
qemuDomainObjBeginJobWithDriver still accesses the qemud_driver
structure and the lock singaling is done through a separate parameter.
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index ff56c463a5..427258d4a5 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -880,8 +880,7 @@ int qemuDomainObjBeginAsyncJob(struct qemud_driver *driver,
 }
 
 /*
- * obj must be locked before calling. If qemud_driver is passed, it MUST be
- * locked; otherwise it MUST NOT be locked.
+ * obj and qemud_driver must be locked before calling.
  *
  * This must be called by anything that will change the VM state
  * in any way, or anything that will use the QEMU monitor.