From: Ian Jackson Date: Wed, 23 Oct 2019 12:55:54 +0000 (+0100) Subject: libxl: On ARM, reject future new passthrough modes too X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=333d7412796e8fd485bfbb79180a520f7e08bc27;p=people%2Fsstabellini%2Fxen-unstable.git%2F.git libxl: On ARM, reject future new passthrough modes too This is most pleasantly done by also changing the if to a switch. Suggested-by: Julien Grall CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson Release-acked-by: Juergen Gross Acked-by: Anthony PERARD --- diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 2f1ca69431..34f8a29056 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -1203,9 +1203,15 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, c_info->passthrough = LIBXL_PASSTHROUGH_SHARE_PT; } - if (c_info->passthrough == LIBXL_PASSTHROUGH_SYNC_PT) { + switch (c_info->passthrough) { + case LIBXL_PASSTHROUGH_DISABLED: + case LIBXL_PASSTHROUGH_SHARE_PT: + break; + + default: LOGD(ERROR, domid, - "passthrough=\"sync_pt\" not supported on ARM\n"); + "passthrough=\"%s\" not supported on ARM\n", + libxl_passthrough_to_string(c_info->passthrough)); rc = ERROR_INVAL; goto out; }