From: Michal Privoznik <mprivozn@redhat.com>
Date: Sat, 1 Aug 2015 05:43:58 +0000 (+0200)
Subject: virNetDevParseMcast: Avoid magic constant
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=327bc16a059f615e384376e73cc242d03fa897d9;p=libvirt.git

virNetDevParseMcast: Avoid magic constant

There is no guarantee that an enum start it mapped onto a value
of zero. However, we are guaranteed that enum items are
consecutive integers. Moreover, it's a pity to define an enum to
avoid using magical constants but then using them anyway.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 1e20789b7b..13d0f235ae 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -2708,7 +2708,7 @@ static int virNetDevParseMcast(char *buf, virNetDevMcastEntryPtr mcast)
     char *saveptr;
     char *endptr;
 
-    for (ifindex = 0, next = buf; ifindex < VIR_MCAST_TYPE_LAST; ifindex++,
+    for (ifindex = VIR_MCAST_TYPE_INDEX_TOKEN, next = buf; ifindex < VIR_MCAST_TYPE_LAST; ifindex++,
          next = NULL) {
         token = strtok_r(next, VIR_MCAST_TOKEN_DELIMS, &saveptr);