From: John Ferlan <jferlan@redhat.com>
Date: Tue, 22 Jan 2013 14:40:58 +0000 (-0500)
Subject: nodeinfo: Add coverity[dead_error_begin] and [returned_null] tags
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=316ed4128bb9cbaecac64a0e2f9b3c84bea3ba39;p=libvirt.git

nodeinfo: Add coverity[dead_error_begin] and [returned_null] tags

The use of switch statements inside a bounded for loop resulted in some
false positives regarding the "default:" label which cannot be reached
since each of the other case statements use the possible for loop values.
A [dead_error_begin] was added before the default label.

Commit id ebdbe25a adjusted the algorithm and the caller guarantees that
the 'params' will have a '_' in the name being searched. Add the [returned_null]
tag to the two instances.
---

diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index 477104f784..a05159c343 100644
--- a/src/nodeinfo.c
+++ b/src/nodeinfo.c
@@ -1124,6 +1124,7 @@ nodeSetMemoryParameterValue(virTypedParameterPtr param)
     int ret = -1;
     int rc = -1;
 
+    /* coverity[returned_null] */
     char *field = strchr(param->field, '_');
     field++;
     if (virAsprintf(&path, "%s/%s",
@@ -1161,6 +1162,7 @@ nodeMemoryParametersIsAllSupported(virTypedParameterPtr params,
     for (i = 0; i < nparams; i++) {
         virTypedParameterPtr param = &params[i];
 
+        /* coverity[returned_null] */
         char *field = strchr(param->field, '_');
         field++;
         if (virAsprintf(&path, "%s/%s",
@@ -1413,6 +1415,7 @@ nodeGetMemoryParameters(virConnectPtr conn ATTRIBUTE_UNUSED,
 
             break;
 
+        /* coverity[dead_error_begin] */
         default:
             break;
         }