From: Roger Pau Monné <roger.pau@citrix.com>
Date: Mon, 17 Feb 2025 12:23:50 +0000 (+0100)
Subject: x86/smp: perform disabling on interrupts ahead of AP shutdown
X-Git-Tag: RELEASE-4.19.2~52
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=30aadc8dbc9ac1abf88bfeb370d1c27c5ea9d1e6;p=xen.git

x86/smp: perform disabling on interrupts ahead of AP shutdown

Move the disabling of interrupt sources so it's done ahead of the offlining
of APs.  This is to prevent AMD systems triggering "Receive accept error"
when interrupts target CPUs that are no longer online.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
master commit: db6daa9bf411260d2c1f5301e4fc786ae4a5cef8
master date: 2025-02-12 15:56:07 +0100
---

diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c
index bd92496d3d..eb134ecac8 100644
--- a/xen/arch/x86/smp.c
+++ b/xen/arch/x86/smp.c
@@ -372,6 +372,8 @@ void smp_send_stop(void)
         smp_call_function(stop_this_cpu, &stop_aps, 0);
 
     local_irq_disable();
+    disable_IO_APIC();
+    hpet_disable();
 
     if ( num_online_cpus() > 1 )
     {
@@ -387,8 +389,6 @@ void smp_send_stop(void)
 
     if ( cpu_online(cpu) )
     {
-        disable_IO_APIC();
-        hpet_disable();
         __stop_this_cpu();
         x2apic_enabled = (current_local_apic_mode() == APIC_MODE_X2APIC);
     }