From: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Tue, 28 Nov 2017 18:48:07 +0000 (+0000)
Subject: x86/traps: Drop redundant printk() in fatal_trap()
X-Git-Tag: 4.11.0-rc1~799
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=30867b3c5a6dcf83426487fc431b395393db662c;p=xen.git

x86/traps: Drop redundant printk() in fatal_trap()

show_page_walk() already prints the linear address of the walk, and
show_execution_state() has printed a raw %cr2 value.  This avoids having
two adjacent log lines with identical information.

  (XEN) Faulting linear address: 00000000025ff028
  (XEN) Pagetable walk from 00000000025ff028:
  ...

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---

diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 86506f3747..c9a849ce84 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -650,11 +650,7 @@ void fatal_trap(const struct cpu_user_regs *regs, bool show_remote)
         show_execution_state(regs);
 
         if ( trapnr == TRAP_page_fault )
-        {
-            unsigned long cr2 = read_cr2();
-            printk("Faulting linear address: %p\n", _p(cr2));
-            show_page_walk(cr2);
-        }
+            show_page_walk(read_cr2());
 
         if ( show_remote )
         {