From: Norbert Manthey <nmanthey@amazon.com>
Date: Fri, 17 Feb 2017 10:47:46 +0000 (+0100)
Subject: lowmemd: fix comparison in cleanup
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=2f5af2c962c05b789bdd65b46c74711e903f86d0;p=people%2Froyger%2Fxen.git

lowmemd: fix comparison in cleanup

The variable virq_port of type uint32_t was compared to being greater than
-1. This check always results in false for unsigned data types, resulting
in never cleaning up the memory. Furthermore, the initialization with a
negative variable for an unsigned type has been fixed.

Signed-off-by: Norbert Manthey <nmanthey@amazon.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---

diff --git a/tools/misc/xen-lowmemd.c b/tools/misc/xen-lowmemd.c
index 32004049a1..865a54cec1 100644
--- a/tools/misc/xen-lowmemd.c
+++ b/tools/misc/xen-lowmemd.c
@@ -10,14 +10,14 @@
 #include <stdlib.h>
 #include <string.h>
 
-static evtchn_port_t virq_port      = -1;
+static evtchn_port_t virq_port      = ~0;
 static xenevtchn_handle *xce_handle = NULL;
 static xc_interface *xch            = NULL;
 static struct xs_handle *xs_handle  = NULL;
 
 void cleanup(void)
 {
-    if (virq_port > -1)
+    if (virq_port != ~0)
         xenevtchn_unbind(xce_handle, virq_port);
     if (xce_handle)
         xenevtchn_close(xce_handle);