From: Erik Skultety <eskultet@redhat.com>
Date: Thu, 4 Dec 2014 13:37:09 +0000 (+0100)
Subject: util: check for an illegal character in a XML namespace prefix
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=2c22954f99a70ed654e4116a18f433afa24d41c5;p=libvirt.git

util: check for an illegal character in a XML namespace prefix

When user tries to insert element metadata providing a namespace
declaration as well, currently we insert the element without any validation
check for XML prefix (if provided). The next VM start would then
fail with parse error. This patch fixes this issue by adding a call to
xmlValidateNCName function to check for illegal characters in the
prefix.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1143921
---

diff --git a/src/util/virxml.c b/src/util/virxml.c
index 7f591fb4f1..93f8590cde 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -1066,6 +1066,12 @@ virXMLInjectNamespace(xmlNodePtr node,
 {
     xmlNsPtr ns;
 
+    if (xmlValidateNCName((const unsigned char *)key, 1) != 0) {
+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                       _("failed to validate prefix for a new XML namespace"));
+        return -1;
+    }
+
     if (!(ns = xmlNewNs(node, (const unsigned char *)uri, (const unsigned char *)key))) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        _("failed to create a new XML namespace"));