From: Peter Maydell Date: Thu, 16 Jun 2011 16:37:14 +0000 (+0100) Subject: linux-user/signal.c: Remove only-ever-set variable fpu_save_addr X-Git-Tag: qemu-xen-4.3.0-rc1~2635^2~2 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=2aec3a27d78075c4b4c44a241f32f27e9a7b9a8a;p=qemu-upstream-4.5-testing.git linux-user/signal.c: Remove only-ever-set variable fpu_save_addr Move the access of fpu_save into the commented out skeleton code for restoring FPU registers on SPARC sigreturn, thus silencing a gcc 4.6 "variable set but never used" warning. (This doesn't affect the calculation of 'err' because in fact __get_user() can never fail.) Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- diff --git a/linux-user/signal.c b/linux-user/signal.c index cb7138f1c..4edd974ce 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -2080,7 +2080,6 @@ long do_sigreturn(CPUState *env) uint32_t up_psr, pc, npc; target_sigset_t set; sigset_t host_set; - abi_ulong fpu_save_addr; int err, i; sf_addr = env->regwptr[UREG_FP]; @@ -2120,10 +2119,11 @@ long do_sigreturn(CPUState *env) err |= __get_user(env->regwptr[i + UREG_I0], &sf->info.si_regs.u_regs[i+8]); } - err |= __get_user(fpu_save_addr, &sf->fpu_save); - - //if (fpu_save) - // err |= restore_fpu_state(env, fpu_save); + /* FIXME: implement FPU save/restore: + * __get_user(fpu_save, &sf->fpu_save); + * if (fpu_save) + * err |= restore_fpu_state(env, fpu_save); + */ /* This is pretty much atomic, no amount locking would prevent * the races which exist anyways.