From: Ján Tomko <jtomko@redhat.com>
Date: Mon, 21 Jan 2019 13:48:18 +0000 (+0100)
Subject: virQEMUDriverConfigLoadNVRAMEntry: use VIR_AUTOFREE
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=2a33dc41bbadf5d37fe162f9e6b7759d2e824fbd;p=libvirt.git

virQEMUDriverConfigLoadNVRAMEntry: use VIR_AUTOFREE

Switch the function to use VIR_AUTOFREE and VIR_AUTOPTR macros
to get rid of the cleanup section.

Requested-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 1e2340b019..1d805993a9 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -829,31 +829,27 @@ static int
 virQEMUDriverConfigLoadNVRAMEntry(virQEMUDriverConfigPtr cfg,
                                   virConfPtr conf)
 {
-    char **nvram = NULL;
-    int ret = -1;
+    VIR_AUTOPTR(virString) nvram = NULL;
     size_t i;
 
     if (virConfGetValueStringList(conf, "nvram", false, &nvram) < 0)
-        goto cleanup;
+        return -1;
     if (nvram) {
         virFirmwareFreeList(cfg->firmwares, cfg->nfirmwares);
 
         cfg->nfirmwares = virStringListLength((const char *const *)nvram);
         if (nvram[0] && VIR_ALLOC_N(cfg->firmwares, cfg->nfirmwares) < 0)
-            goto cleanup;
+            return -1;
 
         for (i = 0; nvram[i] != NULL; i++) {
             if (VIR_ALLOC(cfg->firmwares[i]) < 0)
-                goto cleanup;
+                return -1;
             if (virFirmwareParse(nvram[i], cfg->firmwares[i]) < 0)
-                goto cleanup;
+                return -1;
         }
     }
 
-    ret = 0;
- cleanup:
-    virStringListFree(nvram);
-    return ret;
+    return 0;
 }