From: John Ferlan <jferlan@redhat.com>
Date: Thu, 16 Jul 2015 16:28:58 +0000 (-0400)
Subject: rbd: Return error from rbd_create for message processing
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=279238fea314a9cd9c3e138876702004660e951a;p=libvirt.git

rbd: Return error from rbd_create for message processing

Resolving an error reporting bug introduced by commit id '761491e' which
just took the return of virStorageBackendRBDCreateImage and used it as
the basis for the message generated. This would generate EPERM regardless
of error seen.
---

diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
index 1e35c1f6db..ac5085a9c6 100644
--- a/src/storage/storage_backend_rbd.c
+++ b/src/storage/storage_backend_rbd.c
@@ -484,10 +484,7 @@ static int virStorageBackendRBDCreateImage(rados_ioctx_t io,
                                            char *name, long capacity)
 {
     int order = 0;
-    if (rbd_create(io, name, capacity, &order) < 0)
-        return -1;
-
-    return 0;
+    return rbd_create(io, name, capacity, &order);
 }
 
 static int