From: George Dunlap Date: Thu, 24 Mar 2016 17:17:22 +0000 (+0000) Subject: libxl: Remove pointless hypercall from libxl_set_memory_target X-Git-Tag: 4.7.0-rc1~314 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=26dbc93a;p=xen.git libxl: Remove pointless hypercall from libxl_set_memory_target There's no obvious reason for the call to xc_domain_getinfolist -- all it seems to be doing is checking that the domain exists; but if it doesn't exist, it will have already failed by this point. NB that this will change the return value for libxl_set_memory_target: now it will return 0 on success, rather than returning 1 (which was the previous behavior). This is more in line with expected behavior, and also allows the caller to distingiush between success and other failure modes (some of which also return 1). Signed-off-by: George Dunlap Acked-by: Ian Jackson --- diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 3471c4c038..5c473e7739 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -4810,11 +4810,6 @@ retry_transaction: libxl__xs_printf(gc, t, GCSPRINTF("%s/memory/target", dompath), "%"PRIu32, new_target_memkb); - rc = xc_domain_getinfolist(ctx->xch, domid, 1, &info); - if (rc != 1 || info.domain != domid) { - abort_transaction = 1; - goto out; - } libxl_dominfo_init(&ptr); xcinfo2xlinfo(ctx, &info, &ptr);