From: Owen Smith <owen.smith@cloud.com>
Date: Fri, 12 May 2023 13:56:45 +0000 (+0100)
Subject: Always log during SettingsRestore
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=255aadad1f8ed1d7282bf0c0c0ff13c857ac556f;p=pvdrivers%2Fwin%2Fxenvif.git

Always log during SettingsRestore

- removes the logging skip if the Settings key is not present
- logs if the interface guid doesnt change

Signed-off-by: Owen Smith <owen.smith@cloud.com>
---

diff --git a/src/xenvif/settings.c b/src/xenvif/settings.c
index dd3c991..4dd4ec4 100644
--- a/src/xenvif/settings.c
+++ b/src/xenvif/settings.c
@@ -622,12 +622,8 @@ SettingsRestore(
                                 SubKeyName,
                                 KEY_READ,
                                 &SubKey);
-    if (!NT_SUCCESS(status)) {
-        if (status == STATUS_OBJECT_NAME_NOT_FOUND)
-            goto done;
-
+    if (!NT_SUCCESS(status))
         goto fail1;
-    }
 
     status = RegistryQuerySzValue(SubKey,
                                   "NetCfgInstanceId",
@@ -658,6 +654,10 @@ SettingsRestore(
                      NetLuid,
                      &Ansi,
                      InterfaceLuid);
+    } else {
+        Info("%s: SettingsCopy not required for %ws\n",
+             SubKeyName,
+             Description);
     }
 
     RtlFreeAnsiString(&Ansi);
@@ -669,7 +669,6 @@ SettingsRestore(
 
     RegistryCloseKey(SubKey);
 
-done:
     return STATUS_SUCCESS;
 
 fail4: