From: Radostin Stoyanov <rstoyanov1@gmail.com>
Date: Tue, 20 Mar 2018 06:48:49 +0000 (+0000)
Subject: esx_vi_generator: Simplify generate_helper_header
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=25409b2dd3478a138cd9ae81bd584d49ac1e2e01;p=libvirt.git

esx_vi_generator: Simplify generate_helper_header

The function generate_helper_header() only returns a formatted string.
This could be achieved without performing string concatenation.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
---

diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
index 8f581c41e2..95521fa1e5 100755
--- a/src/esx/esx_vi_generator.py
+++ b/src/esx/esx_vi_generator.py
@@ -1021,20 +1021,16 @@ class ManagedObject(GenericObject):
 
 
     def generate_helper_header(self):
-        header = ""
-
         # functions
-        header += ("int esxVI_Lookup%s(esxVI_Context *ctx, "
-                                      "const char *name, "
-                                      "esxVI_ManagedObjectReference *root, "
-                                      "esxVI_String *selectedPropertyNameList, "
-                                      "esxVI_%s **item, "
-                                      "esxVI_Occurrence occurrence);\n") \
-                  % (self.name, self.name)
-
-        header += "\n"
-
-        return header
+        return (
+            "int esxVI_Lookup%(name)s(esxVI_Context *ctx,"
+                                     " const char *name,"
+                                     " esxVI_ManagedObjectReference *root,"
+                                     " esxVI_String *selectedPropertyNameList,"
+                                     " esxVI_%(name)s **item,"
+                                     " esxVI_Occurrence occurrence);\n\n"
+            % {"name": self.name}
+        )
 
 
     def generate_source(self):