From: Stefano Stabellini <sstabellini@kernel.org>
Date: Wed, 15 May 2024 22:52:04 +0000 (-0700)
Subject: include/ctype.h: fix MISRA R10.2 violation
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=21611c68702dae2e18cb519a6e166cdceeaff4ca;p=people%2Fandrewcoop%2Fxen.git

include/ctype.h: fix MISRA R10.2 violation

The value returned by __toupper is used in arithmetic operations causing
MISRA C 10.2 violations. Cast to plain char in the toupper macro. Also
do the same in tolower for consistency.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---

diff --git a/xen/include/xen/ctype.h b/xen/include/xen/ctype.h
index 6dec944a37..773ac27aa4 100644
--- a/xen/include/xen/ctype.h
+++ b/xen/include/xen/ctype.h
@@ -48,7 +48,7 @@ static inline unsigned char __toupper(unsigned char c)
 	return c;
 }
 
-#define tolower(c) __tolower(c)
-#define toupper(c) __toupper(c)
+#define tolower(c) ((char)__tolower(c))
+#define toupper(c) ((char)__toupper(c))
 
 #endif