From: Roger Pau Monne <roger.pau@citrix.com>
Date: Thu, 14 Jan 2016 15:06:50 +0000 (+0100)
Subject: libxl: fix _SC_GETPW_R_SIZE_MAX usage
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=2155a0ec7d693a05553e515ce1a1d3783fdc8e53;p=people%2Fliuw%2Flibxenctrl-split%2Fxen.git

libxl: fix _SC_GETPW_R_SIZE_MAX usage

If sysconf(_SC_GETPW_R_SIZE_MAX) fails for any reason just use an initial
buffer size of 2048. This is not a critical failure, and the code that
makes use of this buffer is able to expand it later if required.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 0aaefd9572..a088d71160 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -730,9 +730,10 @@ static int libxl__dm_runas_helper(libxl__gc *gc, const char *username)
 
     buf_size = sysconf(_SC_GETPW_R_SIZE_MAX);
     if (buf_size < 0) {
-        LOGE(ERROR, "sysconf(_SC_GETPW_R_SIZE_MAX) returned error %ld",
-                buf_size);
-        return ERROR_FAIL;
+        buf_size = 2048;
+        LOG(DEBUG,
+"sysconf(_SC_GETPW_R_SIZE_MAX) failed, setting the initial buffer size to %ld",
+            buf_size);
     }
 
     while (1) {