From: Artem Mygaiev Date: Wed, 9 Oct 2019 14:20:16 +0000 (+0300) Subject: xen/char: scif-uart: Remove useless ASSERT condition X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=1eeedaf5a0d9ed6324f3bd5b700bb22eb4355341;p=people%2Fdwmw2%2Fxen.git xen/char: scif-uart: Remove useless ASSERT condition cnt is unsigned, so always >=0 Coverity-ID: 1381848 Signed-off-by: Artem Mygaiev [julien: Update commit title] Acked-by: Julien Grall --- diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c index fa0b8274ca..9d3f66b55b 100644 --- a/xen/drivers/char/scif-uart.c +++ b/xen/drivers/char/scif-uart.c @@ -205,7 +205,7 @@ static int scif_uart_tx_ready(struct serial_port *port) /* Check number of data bytes stored in TX FIFO */ cnt = scif_readw(uart, SCIF_SCFDR) >> 8; - ASSERT( cnt >= 0 && cnt <= params->fifo_size ); + ASSERT( cnt <= params->fifo_size ); return (params->fifo_size - cnt); }