From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 30 Apr 2013 13:51:40 +0000 (+0100)
Subject: Simplify the Xen get type driver method
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=1cdc465e0e656a531446aa511fa5f9cec9925846;p=libvirt.git

Simplify the Xen get type driver method

There is no point iterating over sub-drivers since the user
would not have a virConnectPtr instance at all if opening
the drivers failed. Just return 'Xen' immediately.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
index d2418df1c4..9977d3198c 100644
--- a/src/xen/xen_driver.c
+++ b/src/xen/xen_driver.c
@@ -491,16 +491,9 @@ unsigned long xenUnifiedVersion(void)
 
 
 static const char *
-xenUnifiedConnectGetType(virConnectPtr conn)
+xenUnifiedConnectGetType(virConnectPtr conn ATTRIBUTE_UNUSED)
 {
-    xenUnifiedPrivatePtr priv = conn->privateData;
-    int i;
-
-    for (i = 0; i < XEN_UNIFIED_NR_DRIVERS; ++i)
-        if (priv->opened[i])
-            return "Xen";
-
-    return NULL;
+    return "Xen";
 }
 
 /* Which features are supported by this driver? */