From: Kaifeng Zhu Date: Fri, 7 Mar 2014 09:50:41 +0000 (+0000) Subject: readline: fix memory corruption when adding history X-Git-Tag: xen-4.6.1~19 X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=1b10783fe24c7c5f22320032e0d4da5aab9da572;p=qemu-xen-traditional.git readline: fix memory corruption when adding history idx can be down to 0, so TERM_MAX_CMDS-idx+1 could be TERM_MAX_CMDS+1, which exceeds the size of term_history. Signed-off-by: Kaifeng Zhu Coverity-ID: 1055739 Reviewed-by: Andrew Cooper --- diff --git a/readline.c b/readline.c index 85728412..4b687265 100644 --- a/readline.c +++ b/readline.c @@ -267,7 +267,7 @@ static void term_hist_add(const char *cmdline) new_entry = hist_entry; /* Put this entry at the end of history */ memmove(&term_history[idx], &term_history[idx + 1], - (TERM_MAX_CMDS - idx + 1) * sizeof(char *)); + (TERM_MAX_CMDS - (idx + 1)) * sizeof(char *)); term_history[TERM_MAX_CMDS - 1] = NULL; for (; idx < TERM_MAX_CMDS; idx++) { if (term_history[idx] == NULL)