From: Wen Congyang <wency@cn.fujitsu.com>
Date: Wed, 30 Mar 2011 07:46:33 +0000 (+0800)
Subject: do not lock vm while allocating memory
X-Git-Url: http://xenbits.xensource.com/gitweb?a=commitdiff_plain;h=19f916a764ed471a98223310a373f06671cafcaa;p=people%2Fliuw%2Flibxenctrl-split%2Flibvirt.git

do not lock vm while allocating memory

There is no need to lock vm while allocating memory. If allocating
memory failed, we forgot to unlock vm.
---

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 2fc2b6c6a..6c5ae2f70 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -525,8 +525,6 @@ qemuProcessHandleGraphics(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
     virDomainEventGraphicsSubjectPtr subject = NULL;
     int i;
 
-    virDomainObjLock(vm);
-
     if (VIR_ALLOC(localAddr) < 0)
         goto no_memory;
     localAddr->family = localFamily;
@@ -560,6 +558,7 @@ qemuProcessHandleGraphics(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
         subject->nidentity++;
     }
 
+    virDomainObjLock(vm);
     event = virDomainEventGraphicsNewFromObj(vm, phase, localAddr, remoteAddr, authScheme, subject);
     virDomainObjUnlock(vm);